PU2: Added explanation for dependency changes.
Signed-off-by: Skyball2000 <thomas3654william@gmail.com>main
parent
6dbc61fa6b
commit
f91dfe331f
|
@ -13,7 +13,7 @@ import Date exposing (..)
|
||||||
|
|
||||||
|
|
||||||
{-
|
{-
|
||||||
NOTE:
|
1. NOTE:
|
||||||
The Date.sub implementation provided is broken. It will not terminate given specific parameters, such as (29, 2, 2022) (21, 12, 2022).
|
The Date.sub implementation provided is broken. It will not terminate given specific parameters, such as (29, 2, 2022) (21, 12, 2022).
|
||||||
We have replaced it with our own implementation seen below, which is also more efficient, running in O(1) compared to O(n):
|
We have replaced it with our own implementation seen below, which is also more efficient, running in O(1) compared to O(n):
|
||||||
|
|
||||||
|
@ -46,6 +46,23 @@ NOTE:
|
||||||
y2 = y + (mi + 2) // 12 -- y = y2
|
y2 = y + (mi + 2) // 12 -- y = y2
|
||||||
dd = ddd - (mi * 306 + 5) // 10 + 1
|
dd = ddd - (mi * 306 + 5) // 10 + 1
|
||||||
in (dd, mm, y2)
|
in (dd, mm, y2)
|
||||||
|
|
||||||
|
2. NOTE:
|
||||||
|
We had to move the elm/time dependency from "indirect" to "direct" in order to be able to use the Time.Posix, Time.Zone and Time.Month types.
|
||||||
|
With that, our dependencies are the following:
|
||||||
|
"dependencies": {
|
||||||
|
"direct": {
|
||||||
|
"elm/browser": "1.0.2",
|
||||||
|
"elm/core": "1.0.5",
|
||||||
|
"elm/html": "1.0.0",
|
||||||
|
"elm/time": "1.0.0"
|
||||||
|
},
|
||||||
|
"indirect": {
|
||||||
|
"elm/json": "1.1.3",
|
||||||
|
"elm/url": "1.0.0",
|
||||||
|
"elm/virtual-dom": "1.0.3"
|
||||||
|
}
|
||||||
|
}
|
||||||
-}
|
-}
|
||||||
|
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue